👩🌾 Fix deprecation warnings #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
azeey
approved these changes
Jan 20, 2021
| @@ -32,6 +32,8 @@ namespace ignition | |||
| { | |||
| namespace gazebo | |||
| { | |||
| // Inline bracket to help doxygen filtering. | |||
| inline namespace IGNITION_GAZEBO_VERSION_NAMESPACE { | |||
| @@ -59,7 +59,7 @@ set(IGN_MSGS_VER ${ignition-msgs7_VERSION_MAJOR}) | |||
| #-------------------------------------- | |||
| # Find ignition-common | |||
| # Always use the profiler component to get the headers, regardless of status. | |||
| ign_find_package(ignition-common3 VERSION 3.5 | |||
| ign_find_package(ignition-common3 VERSION 3.6 | |||
There was a problem hiding this comment.
Is this version bump also for fixing warnings?
There was a problem hiding this comment.
It's actually failing the build fast... I used a new machine and noticed that building against common 3.5 fails because ign-gazebo is using the API from gazebosim/gz-common#70
Codecov Report
@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 77.57% 77.55% -0.02%
==========================================
Files 211 211
Lines 11582 11581 -1
==========================================
- Hits 8985 8982 -3
- Misses 2597 2599 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings introduced in #546.
Also fixed gazebosim/gz-launch#88, which was caused by a missing inline namespace.
I recommend viewing the diff without whitespace.
https://github.com/osrf/buildfarmer/issues/145