👩‍🌾 Make depth camera tests more robust

[chapulina]

Signed-off-by: Louise Poubel [email protected]

🦟 Bug fix

Summary

This test has been flaky on Linux, failing with:

165: /var/lib/jenkins/workspace/ignition_gazebo-ci-ign-gazebo5-bionic-amd64/ign-gazebo/test/integration/depth_camera.cc:98: Failure
165: Expected: (depthBuffer) != (nullptr), actual: NULL vs (nullptr)
165/182 Test #165: INTEGRATION_depth_camera ...............................***Exception: SegFault  1.83 sec

Here's the test history:

https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo5-bionic-amd64/19/testReport/(root)/INTEGRATION_depth_camera/test_ran/history/

Most likely, it's quitting before it receives the message. This PR allows more time to receive the message, and stops waiting when the message is received.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

https://github.com/osrf/buildfarmer/issues/207

[codecov]

Codecov Report

Merging #897 (ce44ede) into ign-gazebo5 (d3ee64a) will increase coverage by 0.25%.
The diff coverage is 63.43%.

❗ Current head ce44ede differs from pull request most recent head 3835f4b. Consider uploading reports for the commit 3835f4b to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo5     #897      +/-   ##
===============================================
+ Coverage        65.32%   65.57%   +0.25%     
===============================================
  Files              240      243       +3     
  Lines            17624    18304     +680     
===============================================
+ Hits             11513    12003     +490     
- Misses            6111     6301     +190     

Impacted Files	Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh	100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh	100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc	6.69% <0.00%> (-0.52%)	⬇️
src/gui/plugins/scene3d/Scene3D.hh	50.00% <ø> (-16.67%)	⬇️
src/gui/plugins/shapes/Shapes.cc	22.72% <ø> (ø)
.../gui/plugins/transform_control/TransformControl.cc	18.00% <0.00%> (+2.87%)	⬆️
src/rendering/SceneManager.cc	24.88% <0.00%> (-0.20%)	⬇️
...ms/joint_traj_control/JointTrajectoryController.cc	78.20% <ø> (ø)
...ms/joint_traj_control/JointTrajectoryController.hh	100.00% <ø> (ø)
src/systems/physics/Physics.hh	100.00% <ø> (ø)
... and 44 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276ec0f...3835f4b. Read the comment docs.

[ahcorde]

what's about the thermal_sensor_system.cc ? I think it's failing for a similar reason.

[chapulina]

thermal_sensor_system

Good call, increased the time in 082f28c

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1