Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #656 #993

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Backport #656 #993

merged 2 commits into from
Oct 11, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Aug 25, 2021

Signed-off-by: Ashton Larkin [email protected]

#656 was targeted at Dome, but it can be backported to Citadel to help with performance a bit.

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ashton Larkin <[email protected]>
@adlarkin adlarkin requested a review from azeey as a code owner August 25, 2021 01:20
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 25, 2021
@adlarkin adlarkin requested a review from chapulina August 25, 2021 01:21
@chapulina chapulina added the performance Runtime performance label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #993 (a3aad5a) into ign-gazebo3 (c625586) will increase coverage by 0.01%.
The diff coverage is 73.50%.

❗ Current head a3aad5a differs from pull request most recent head 80c3461. Consider uploading reports for the commit 80c3461 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #993      +/-   ##
===============================================
+ Coverage        77.79%   77.81%   +0.01%     
===============================================
  Files              221      221              
  Lines            12687    12714      +27     
===============================================
+ Hits              9870     9893      +23     
- Misses            2817     2821       +4     
Impacted Files Coverage Δ
src/systems/physics/Physics.cc 70.12% <73.50%> (-0.22%) ⬇️
src/SimulationRunner.cc 94.49% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c625586...80c3461. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chapulina chapulina merged commit bed3a93 into ign-gazebo3 Oct 11, 2021
@chapulina chapulina deleted the adlarkin/backport_physics_caching branch October 11, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel performance Runtime performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants