Using std::chrono instead of common::Time #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
We should check who's using those functions and make sure to update them before committing to deprecating them. I think here the only case is for the |
Signed-off-by: ahcorde <[email protected]>
…ics/ign-gui into ahcorde/std_chrono
Signed-off-by: ahcorde <[email protected]>
…ics/ign-gui into ahcorde/std_chrono
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
chapulina
reviewed
Sep 5, 2020
chapulina
added
needs upstream release
chapulina
reviewed
Sep 10, 2020
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 63.07% 63.13% +0.05%
==========================================
Files 20 20
Lines 2592 2596 +4
==========================================
+ Hits 1635 1639 +4
Misses 957 957
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
…gui into ahcorde/std_chrono
Signed-off-by: Louise Poubel <[email protected]>
chapulina
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with this issue gazebosim/gz-common#61. The idea it's to deprecate the class
common::Timein favor ofstd::chrono.Related with
Should I deprecate the methods/functions that use common:Time ?
Signed-off-by: ahcorde [email protected]