Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate valid topics depending on world name #164

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

chapulina
Copy link
Contributor

Redo of #163 targeting Dome.

Part of gazebosim/gz-sim#239 is making sure that all topics can handle entity names with spaces. This can be the case for the world.

This makes use of the AsValidTopic function to convert world names to valid ones whenever possible.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #164 (da16923) into ign-gui4 (ce4bf4f) will decrease coverage by 0.00%.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui4     #164      +/-   ##
============================================
- Coverage     61.57%   61.57%   -0.01%     
============================================
  Files            21       21              
  Lines          2790     2803      +13     
============================================
+ Hits           1718     1726       +8     
- Misses         1072     1077       +5     
Impacted Files Coverage Δ
src/plugins/world_stats/WorldStats.cc 94.78% <40.00%> (-2.50%) ⬇️
src/plugins/world_control/WorldControl.cc 79.20% <75.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4bf4f...da16923. Read the comment docs.

@JShep1 JShep1 self-requested a review December 30, 2020 23:51
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with all tests passing

@chapulina chapulina merged commit 901fc8f into ign-gui4 Jan 5, 2021
@chapulina chapulina deleted the chapulina/4/valid_topics branch January 5, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants