-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added log storing for ign-gui #272
Conversation
How do I write a test for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I just have a small comment. Nice idea to put this into ignitionVersion
, since that's called every time the user runs ign gui
!
You could write a test similar to this one: And check that the file was created. I recommend setting the So that when the user runs tests, no files are created in their home folder. |
Signed-off-by: Nikhil Nair <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR, @NickNair !
I rebased on top of ign-gui3
(Citadel), and after merged we can merge it forward.
Also pushed these changes in b9d8345:
- Changed directory from
gazebo
togui
- Moved functionality to a new function for clarity, so in case we stop calling
ignitionVersion
every time, this still works - Added a test
- Added a note to the tutorial
Maybe @jennuine can take a look too since I've touched a lot of the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor comment
Signed-off-by: Louise Poubel <[email protected]>
* Added log storing for ign-gui (#272) Signed-off-by: Nikhil Nair <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Don't crash if a plugin has invalid QML (#315) Signed-off-by: Louise Poubel <[email protected]> * Set marker point size from message (#317) Signed-off-by: Louise Poubel <[email protected]> * Don't set visual scale for point markers (#321) Signed-off-by: Louise Poubel <[email protected]> * Fix TopicEcho plugin message display (#322) - Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <[email protected]> * Use qmldir to define QML module with IgnSpinBox (#319) Signed-off-by: William Wedler <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Add PreRender event to MinimalScene (#325) Signed-off-by: Louise Poubel <[email protected]> * Offer a way to disable warnings on marker manager (#326) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> * Fix codecheck (#329) Signed-off-by: Louise Poubel <[email protected]> * Fix codecheck (#332) Signed-off-by: Louise Poubel <[email protected]> * Grid config: set values from startup and improve layout (#324) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nikhil Nair <[email protected]> Co-authored-by: Rhys Mainwaring <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🎉 New feature
Closes #962 from ign-gazebo repository
Summary
Every time a simulation is run with the GUI, the GUI console logs are saved to ~/.ignition/gazebo/log//gui_console.log
Test it
Run a simulation. Then :
`cd /.ignition/gazebo/log/
cat gui_console.log`
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge