Fix tests on actions #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui2 #98 +/- ##
=============================================
+ Coverage 14.55% 60.18% +45.62%
=============================================
Files 13 16 +3
Lines 1333 2082 +749
=============================================
+ Hits 194 1253 +1059
+ Misses 1139 829 -310
Continue to review full report at Codecov.
|
|
+45.62% test coverage at once 😄 |
mjcarroll
reviewed
Aug 3, 2020
mjcarroll
reviewed
Aug 3, 2020
| @@ -81,10 +81,7 @@ function(ign_gui_add_plugin plugin_name) | |||
| PRIVATE_LINK_LIBS ${ign_gui_add_plugin_PRIVATE_LINK_LIBS} ignition-plugin${IGN_PLUGIN_VER}::register | |||
| ) | |||
|
|
|||
| message(STATUS "ddddddddddddddddddddddddddddddddddddddddd") | |||
mjcarroll
approved these changes
Aug 3, 2020
We haven't released Blueprint debs for Focal, so we'd need to build dependencies from source. So my plan is to add Focal from Citadel 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the action style.