Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting topic names and message types #102

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 25, 2021

🎉 New feature

Summary

Support returning a list of topics and their message types using the websocket server.

Test it

Run the websocket server, and request "topics-types". You can test using https://gitlab.com/ignitionrobotics/web/app/-/merge_requests/111

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@nkoenig nkoenig requested review from iche033 and german-e-mas March 25, 2021 21:09
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #102 (270ee84) into ign-launch3 (77f736a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch3     #102   +/-   ##
============================================
  Coverage        30.24%   30.24%           
============================================
  Files                3        3           
  Lines              734      734           
============================================
  Hits               222      222           
  Misses             512      512           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f736a...270ee84. Read the comment docs.

@german-e-mas
Copy link
Contributor

LGTM! Works as intended.

@nkoenig
Copy link
Contributor Author

nkoenig commented Apr 7, 2021

@osrf-jenkins run tests please.

@nkoenig nkoenig merged commit 88c2355 into ign-launch3 Apr 9, 2021
@nkoenig nkoenig deleted the topics-types branch April 9, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants