-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gtest for Windows compilation #122
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-launch2 #122 +/- ##
============================================
Coverage 30.24% 30.24%
============================================
Files 3 3
Lines 734 734
============================================
Hits 222 222
Misses 512 512 Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
Windows CI is failing
Is this something that will need to be done across all of the ignition libraries as well? |
I would say that windows CI should not compile.
The other packages are able to run tests. I think |
@osrf-jenkins retest this please |
Since Windows CI for |
This should prevent Windows CI from being triggered for branches other than |
Signed-off-by: ahcorde [email protected]
🎉 Enhancement
Summary
Update gtest for Windows compilation.
Part of this PR #120
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge