Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gtest for Windows compilation #122

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 14, 2021

Signed-off-by: ahcorde [email protected]

🎉 Enhancement

Summary

Update gtest for Windows compilation.

Part of this PR #120

Checklist

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde added the tests Broken or missing tests / testing infra label Jul 14, 2021
@ahcorde ahcorde self-assigned this Jul 14, 2021
@ahcorde ahcorde requested a review from nkoenig as a code owner July 14, 2021 12:00
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #122 (764ece5) into ign-launch2 (69da24d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch2     #122   +/-   ##
============================================
  Coverage        30.24%   30.24%           
============================================
  Files                3        3           
  Lines              734      734           
============================================
  Hits               222      222           
  Misses             512      512           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69da24d...764ece5. Read the comment docs.

@ahcorde ahcorde requested a review from mjcarroll July 14, 2021 15:09
@mjcarroll
Copy link
Contributor

Windows CI is failing

CMake Error at src/msgs/CMakeLists.txt:1 (PROTOBUF_GENERATE_CPP):
  Unknown CMake command "PROTOBUF_GENERATE_CPP".

Is this something that will need to be done across all of the ignition libraries as well?

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 14, 2021

@mjcarroll

I would say that windows CI should not compile.

Is this something that will need to be done across all of the ignition libraries as well?

The other packages are able to run tests. I think ign-launch is the last one without windows support. I would say no.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 16, 2021

@osrf-jenkins retest this please

@mjcarroll
Copy link
Contributor

ign-gazebo3 is disabled on Windows CI currently, presumably because it doesn't build on Windows: https://build.osrfoundation.org/view/ign-citadel/job/ign_gazebo-ign-3-win/

Since Windows CI for ign-launch depends on gazebo correctly building, it's safe to say it will never pass here, and can be ignored.

@ahcorde ahcorde merged commit 5347cd0 into ign-launch2 Jul 16, 2021
@ahcorde ahcorde deleted the ahcorde/update/gtest branch July 16, 2021 15:05
@chapulina
Copy link
Contributor

it will never pass here, and can be ignored.

This should prevent Windows CI from being triggered for branches other than main: gazebo-tooling/release-tools#492

@chapulina chapulina added the Windows Windows support label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel tests Broken or missing tests / testing infra Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants