Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IGN_LAUNCH_CONFIG_PATH #131

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Use IGN_LAUNCH_CONFIG_PATH #131

merged 1 commit into from
Sep 29, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 28, 2021

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Summary

The new CLI did not use the IGN_LAUNCH_CONFIG_PATH environment variable.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 28, 2021
@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working labels Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #131 (5c1e7bb) into main (1c1ef98) will decrease coverage by 0.32%.
The diff coverage is 27.77%.

❗ Current head 5c1e7bb differs from pull request most recent head b1334b5. Consider uploading reports for the commit b1334b5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   33.25%   32.92%   -0.33%     
==========================================
  Files           4        4              
  Lines         806      817      +11     
==========================================
+ Hits          268      269       +1     
- Misses        538      548      +10     
Impacted Files Coverage Δ
src/cmd/launch_main.cc 74.60% <27.77%> (-13.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1ef98...b1334b5. Read the comment docs.

@ahcorde
Copy link
Contributor

ahcorde commented Sep 29, 2021

@osrf-jenkins retest this please

@nkoenig nkoenig merged commit e9a6148 into main Sep 29, 2021
@nkoenig nkoenig deleted the use_config_path_env branch September 29, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants