Added <max_connections> to the websocket server #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-launch1 #40 +/- ##
============================================
Coverage 28.15% 28.15%
============================================
Files 3 3
Lines 721 721
============================================
Hits 203 203
Misses 518 518 Continue to review full report at Codecov.
|
german-e-mas
approved these changes
Jul 28, 2020
| ignerr << "Failed to convert port[" << elem->GetText() << "] to integer." | ||
| << std::endl; | ||
| } | ||
| igndbg << "Using maximum connetion count of " |
There was a problem hiding this comment.
Typo: connetion → connection
| @@ -374,6 +404,9 @@ void WebsocketServer::OnConnect(int _socketId) | |||
| ////////////////////////////////////////////////// | |||
| void WebsocketServer::OnDisconnect(int _socketId) | |||
| { | |||
| if (this->connections.find(_socketId) == this->connections.end()) | |||
There was a problem hiding this comment.
I would add the comment Skip invalid sockets here as well.
Signed-off-by: Nate Koenig <[email protected]>
Yeah, that's right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports setting the maximum number of websocket connections.
Signed-off-by: Nate Koenig [email protected]