Add PKGCONFIG information to ignition-tools ign_find_package #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
j-rivero
force-pushed
the
remove_warning_tools
branch
from
df9f77d to
7318f24
Compare
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 28.03% 28.03%
=======================================
Files 3 3
Lines 724 724
=======================================
Hits 203 203
Misses 521 521 Continue to review full report at Codecov.
|
chapulina
previously approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Nice! This closes gazebosim/gz-tools#23. I think we should also change other libraries to find ign-tools as REQUIRED.
|
The warning is gone from Ubuntu 🎉 But the Homebrew build failed due to infrastructure. I triggered a new build: |
|
Humm this changes something on macOS: |
CI seems to be passing, running a new one to see if it is a flaky. |
nkoenig
approved these changes
Aug 17, 2020
chapulina
approved these changes
Aug 18, 2020
chapulina
pushed a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Aug 25, 2020
Signed-off-by: Jose Luis Rivero <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Aug 25, 2020
Signed-off-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to clean up warning about the use of ignition-tools in the
ign_find_packagecall.