Websocket server metrics endpoint #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejo Carballude <[email protected]>
Signed-off-by: Alejo Carballude <[email protected]>
AlejoAsd
force-pushed
the
websocket_server_metrics
branch
from
626b896 to
d36afa0
Compare
AlejoAsd
changed the title
AlejoAsd
changed the title
Signed-off-by: Alejo Carballude <[email protected]>
AlejoAsd
force-pushed
the
websocket_server_metrics
branch
from
6ca4214 to
12cec70
Compare
Signed-off-by: Alejo Carballude <[email protected]>
nkoenig
reviewed
Aug 11, 2020
Signed-off-by: Alejo Carballude <[email protected]>
Signed-off-by: Alejo Carballude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
/metricsHTTP endpoint to the websocket server using libwebsockets HTTP capabilities.The
/metricsendpoint currently returns the number of active websocket connections. It will be used to monitor and scale websocket server deployments.Note: No new
lwsprotocols were added to support HTTP. Instead, theLWS_CALLBACK_HTTPevent is first handled byrootCallbackand delegated tohttpCallback. It was implemented this way because HTTP requests do not provide protocol names and end up defaulting torootCallback.