Implement AxisAlignedBox Volume function #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
github-actions
bot
added
🏰 citadel
Codecov Report
@@ Coverage Diff @@
## ign-math6 #126 +/- ##
==========================================
Coverage 99.50% 99.50%
==========================================
Files 59 59
Lines 5660 5662 +2
==========================================
+ Hits 5632 5634 +2
Misses 28 28
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jun 10, 2020
|
update changelog? |
Signed-off-by: Ian Chen <[email protected]>
|
updated changelog. 52c19b8 |
scpeters
approved these changes
Jun 10, 2020
|
@osrf-jenkins run tests please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the implementation for the AxisAlignedBox::Volume function.
I noticed that several other functions in the AxisAlignedBox class are missing implementations, e.g.
DensityFromMass,MassMatrix,Material. I not sure if these functions are are supposed to be moved to the AxisAlignedBox class when theBoxclass was refactored in this pull request. Maybe @nkoenig knows more about this?