Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create abs, absDot and Correct functions for Vector2d #143

Merged
merged 5 commits into from
Jul 29, 2020
Merged

Create abs, absDot and Correct functions for Vector2d #143

merged 5 commits into from
Jul 29, 2020

Conversation

ximenesfel
Copy link

  • Abs() => Get the absolute value of the vector
  • AbsDot() => The absolute dot product
  • Correct() => Corrects any nan values

Create unit test for all functions.

Did all checks and tests.

These functions intend to solve issue #71

Signed-off-by: Felipe Ximenes [email protected]

@felximenes
Create abs, absDot and Corerct functions for Vector2d
2c6f6ea 
- Abs() => Get the absolute value of the vector
- AbsDot() => The absolute dot product
- Correct() => Corrects any nan values

Create unit test for all functions.

Did all checks and tests.

These functions intend to solve issue gazebosim#71

Signed-off-by: Felipe Ximenes <[email protected]>
@ximenesfel ximenesfel requested a review from scpeters as a code owner July 26, 2020 22:46
@ximenesfel
Copy link
Author

After creating the pull request the following CI checks does not passed:

Ticket opened / Add ticket to inbox (pull_request)

Action:   opened
sha:      d641c46767ef7b5c23c60ce4562043eed42fba1c
ref:      refs/pull/143/merge
Labels:
owner:    ignitionrobotics
repo:     ign-math

Dump context
Dump Payload
==================================================

Error: Input required and not supplied: GITHUB_TOKEN
    at Object.getInput (/home/runner/work/_actions/technote-space/create-project-card-action/v1/node_modules/@actions/core/lib/core.js:78:15)
    at Object.exports.getAccessToken (/home/runner/work/_actions/technote-space/create-project-card-action/v1/node_modules/@technote-space/github-action-helper/dist/utils.js:66:47)
    at Object.exports.getOctokit (/home/runner/work/_actions/technote-space/create-project-card-action/v1/node_modules/@technote-space/github-action-helper/dist/utils.js:67:106)
    at /home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:27:66
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:4:12)
    at run (/home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:19:19)
    at Object.<anonymous> (/home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:29:1)
##[error]Input required and not supplied: GITHUB_TOKEN

Ubuntu Bionic CI / Ubuntu Bionic CI (pull_request)

Unexpected input(s) 'script-after-make', valid inputs are ['entryPoint', 'args', 'github_token', 'apt-dependencies', 'codecov-token', 'cmake-args']

Looking the errors messages, I can't found the reason why the checks failed.

@chapulina chapulina added enhancement New feature or request 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Jul 27, 2020
@chapulina
Copy link
Contributor

I can't found the reason why the checks failed.

That's a problem with our infrastructure, don't worry about it.

@chapulina chapulina requested review from ahcorde and JShep1 July 27, 2020 18:41
@ahcorde ahcorde changed the title Create abs, absDot and Corerct functions for Vector2d Create abs, absDot and Correct functions for Vector2d Jul 28, 2020
ahcorde
ahcorde approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but LGTM

include/ignition/math/Vector2.hh Outdated Show resolved Hide resolved
@felximenes @ahcorde
Update include/ignition/math/Vector2.hh
05f31b0 
nit: Upper case after an argument name

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Felipe Ximenes <[email protected]>
@ximenesfel ximenesfel force-pushed the abs-absdot-correct-functions branch from 9bcd709 to 05f31b0 Compare July 28, 2020 11:47
felximenes and others added 3 commits July 28, 2020 14:31
@felximenes
Create abs, absDot and Corerct functions for Vector2d
959633c 
- Abs() => Get the absolute value of the vector
- AbsDot() => The absolute dot product
- Correct() => Corrects any nan values

Create unit test for all functions.

Did all checks and tests.

These functions intend to solve issue gazebosim#71

Signed-off-by: Felipe Ximenes <[email protected]>
@felximenes @ahcorde
Update include/ignition/math/Vector2.hh
9d7f206 
nit: Upper case after an argument name

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Felipe Ximenes <[email protected]>
@felximenes
Merge branch 'abs-absdot-correct-functions' of https://github.com/xim…
1d8f288 
…enesfel/ign-math into abs-absdot-correct-functions
@ximenesfel ximenesfel requested a review from ahcorde July 28, 2020 17:50
@chapulina chapulina merged commit a14af06 into gazebosim:ign-math6 Jul 29, 2020
@ximenesfel ximenesfel deleted the abs-absdot-correct-functions branch July 29, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@ahcorde ahcorde ahcorde approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@JShep1 JShep1 Awaiting requested review from JShep1

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ximenesfel @chapulina @ahcorde @felximenes