-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows installation via conda-forge #185
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #185 +/- ##
==========================================
Coverage 99.20% 99.20%
==========================================
Files 63 63
Lines 6020 6020
==========================================
Hits 5972 5972
Misses 48 48 Continue to review full report at Codecov.
|
Signed-off-by: Mabel Zhang <[email protected]>
Updated tutorial so that dependencies are installed via conda-forge releases, and building is via cmake. |
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Small nit but other than that looks good
Signed-off-by: Mabel Zhang <[email protected]> Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
…ics/ign-math into mabelzhang/windows_install
I noticed the rendering of the currently deployed tutorial webpage looks wrong from Prerequisites section downward: https://ignitionrobotics.org/api/math/6.8/install.html I'm not sure what's off, the indentation of the code block under a bullet, or the empty line before it. The ign-physics tutorial looks correct though: https://ignitionrobotics.org/api/physics/3.1/installation.html |
I suggest debugging locally using |
Cool thanks for the tip! All the code blocks look correct for me locally now. Definitely needs 2-space indentation instead of 4 for the code block to render correctly under a bullet, and no empty line before the code block. Doxygen interprets empty lines within an item as the end of the bullet list, unlike GitHub. |
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Partially addresses gazebosim/docs#117
See explanation about why it needs to refer to ign-cmake here gazebosim/gz-cmake#139