Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pose + spherical coordinates combination on spawn #212

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Accompanies the implementation change in

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from caguero as a code owner January 12, 2022 00:48
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 12, 2022
@chapulina chapulina added the documentation Improvements or additions to documentation label Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #212 (9fa5d0f) into ign-msgs8 (020ffb5) will not change coverage.
The diff coverage is n/a.

❗ Current head 9fa5d0f differs from pull request most recent head 7631d8a. Consider uploading reports for the commit 7631d8a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs8     #212   +/-   ##
==========================================
  Coverage      84.56%   84.56%           
==========================================
  Files              7        7           
  Lines            855      855           
==========================================
  Hits             723      723           
  Misses           132      132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020ffb5...7631d8a. Read the comment docs.

@chapulina chapulina merged commit 190931c into ign-msgs8 Jan 13, 2022
@chapulina chapulina deleted the chapulina/8/sc_spawn branch January 13, 2022 23:39
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants