Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cpplint error #201

Merged
merged 1 commit into from
Jan 22, 2021
Merged

fix cpplint error #201

merged 1 commit into from
Jan 22, 2021

Conversation

claireyywang
Copy link
Contributor

Signed-off-by: claireyywang [email protected]

Signed-off-by: claireyywang <[email protected]>
@claireyywang claireyywang self-assigned this Jan 21, 2021
@claireyywang claireyywang requested a review from mxgrey as a code owner January 21, 2021 22:46
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 21, 2021
@claireyywang claireyywang removed the request for review from mxgrey January 21, 2021 22:46
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #201 (f4fc99f) into ign-physics3 (068425f) will decrease coverage by 0.23%.
The diff coverage is 61.29%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics3     #201      +/-   ##
================================================
- Coverage         83.27%   83.03%   -0.24%     
================================================
  Files               106      106              
  Lines              3951     3973      +22     
================================================
+ Hits               3290     3299       +9     
- Misses              661      674      +13     
Impacted Files Coverage Δ
dartsim/src/CustomMeshShape.cc 62.28% <ø> (ø)
dartsim/src/EntityManagementFeatures.cc 73.41% <ø> (ø)
dartsim/src/SDFFeatures.cc 67.34% <ø> (-0.29%) ⬇️
dartsim/src/ShapeFeatures.cc 36.42% <ø> (ø)
include/ignition/physics/BoxShape.hh 100.00% <ø> (ø)
include/ignition/physics/Cloneable.hh 100.00% <ø> (ø)
include/ignition/physics/CylinderShape.hh 100.00% <ø> (ø)
include/ignition/physics/PlaneShape.hh 100.00% <ø> (ø)
include/ignition/physics/SphereShape.hh 100.00% <ø> (ø)
dartsim/src/JointFeatures.cc 67.85% <61.29%> (-2.84%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4c861...f4fc99f. Read the comment docs.

@claireyywang
Copy link
Contributor Author

merging since no changes made to affect the code coverage

@claireyywang claireyywang merged commit 654ef23 into ign-physics3 Jan 22, 2021
@claireyywang claireyywang deleted the claire/add-include branch January 22, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants