Fix dart deprecation warning #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from gazebosim#262. Signed-off-by: Steve Peters <[email protected]>
Merged
Codecov Report
@@ Coverage Diff @@
## ign-physics2 #263 +/- ##
=============================================
Coverage 82.94% 82.94%
=============================================
Files 106 106
Lines 4034 4034
=============================================
Hits 3346 3346
Misses 688 688 Continue to review full report at Codecov.
|
ahcorde
approved these changes
Jun 17, 2021
chapulina
added a commit
that referenced
this pull request
Jun 18, 2021
* [Citadel] Update tutorials (#204) Signed-off-by: claireyywang <[email protected]> Signed-off-by: anindex <[email protected]> Co-authored-by: anindex <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Claire Wang <[email protected]> Co-authored-by: Steve Peters <[email protected]> * Remove tools/code_check and update codecov (#257) Signed-off-by: Louise Poubel <[email protected]> * Fix dart deprecation warning (#263) Copied from #262. Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Claire Wang <[email protected]> Co-authored-by: anindex <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fix for dart deprecation warning copied from #262.
Summary
Keep using the old method for dart 6.9 and earlier, but use the new method for 6.10+.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge