Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake script for bullet #297

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

Tobias-Fischer
Copy link
Contributor

In conda-forge we got this error:

CMake Error at bullet/CMakeLists.txt:37 (target_compile_options):
  Cannot specify compile options for target "PUBLIC" which is not built by
  this project.

This fixes it.

@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Oct 9, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for the fix. Can you sign your commit for DCO? Thanks!

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #297 (23aa79a) into ign-physics5 (f0257d6) will not change coverage.
The diff coverage is n/a.

❗ Current head 23aa79a differs from pull request most recent head cf7c1c9. Consider uploading reports for the commit cf7c1c9 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           ign-physics5     #297   +/-   ##
=============================================
  Coverage         75.54%   75.54%           
=============================================
  Files               127      127           
  Lines              5655     5655           
=============================================
  Hits               4272     4272           
  Misses             1383     1383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0257d6...cf7c1c9. Read the comment docs.

Signed-off-by: Tobias-Fischer <[email protected]>
@Tobias-Fischer
Copy link
Contributor Author

Done @chapulina

@chapulina chapulina merged commit 369bc39 into gazebosim:ign-physics5 Oct 25, 2021
@Tobias-Fischer Tobias-Fischer deleted the patch-2 branch October 25, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants