Add unversioned symlinks for engine plugins #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #141 +/- ##
===============================================
Coverage 50.41% 50.41%
===============================================
Files 129 129
Lines 11682 11682
===============================================
Hits 5889 5889
Misses 5793 5793 Continue to review full report at Codecov.
|
iche033
reviewed
Sep 24, 2020
4 tasks
Signed-off-by: John Shepherd <[email protected]>
iche033
approved these changes
Oct 2, 2020
|
we need to update the debian metadata so that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards getting full support for custom render engines from command line. This PR symlinks binaries that don't contain the version number (same as how physics is doing for
dartsimandtpe) so the user will not have to specify the version of ignition-rendering they are currently using when specifying an engine binary name. More progress towards getting #100 resolvedSigned-off-by: John Shepherd [email protected]