Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light map tutorial #302

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Add light map tutorial #302

merged 2 commits into from
Apr 13, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 9, 2021

Signed-off-by: Ian Chen [email protected]

🎉 New feature

Summary

Adds a light map tutorial for showing how to bake light maps in blender and applying them in Ignition.

Credits go to Rafi and @ColeOSRF for putting together most of the content of this tutorial. I made some minor tweaks to convert them to mark down and added a section on using light maps in Ignition.

Test it

build ignition rendering and that should generation doxygen documentation. View the tutorial by opening <build_dir>/doxygen/html/index.html then going to Tutorials and open Creating and using light maps

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #302 (ba552ca) into ign-rendering5 (d6957d0) will not change coverage.
The diff coverage is n/a.

❗ Current head ba552ca differs from pull request most recent head 187cbe2. Consider uploading reports for the commit 187cbe2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering5     #302   +/-   ##
===============================================
  Coverage           57.53%   57.53%           
===============================================
  Files                 159      159           
  Lines               15591    15591           
===============================================
  Hits                 8971     8971           
  Misses               6620     6620           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6957d0...187cbe2. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

tutorials/04_lightmap.md Outdated Show resolved Hide resolved
tutorials/04_lightmap.md Outdated Show resolved Hide resolved
tutorials/04_lightmap.md Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from ahcorde April 12, 2021 22:17
@iche033 iche033 merged commit d7af955 into ign-rendering5 Apr 13, 2021
@iche033 iche033 deleted the lightmap_tutorial branch April 13, 2021 17:28
iche033 added a commit that referenced this pull request Apr 27, 2021
* add lightmap tutorial

Signed-off-by: Ian Chen <[email protected]>

* feedback

Signed-off-by: Ian Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants