Add SetSize API for LidarVisual

[iche033]

Signed-off-by: Ian Chen [email protected]

🎉 New feature

Summary

Support setting point size for lidar visual.

Currently working for ogre 1.x only. I still need to figure out how to make it work with the ogre2 hlms system.

Update: ogre2 is now working - updated to use ogre low level materials.

Test it

1. Build and run the lidar_visual example.
2. Press 2 to toggle to point rendering and see the points are now slightly larger than before (size increased from 1 to 5):

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #392 (cd65302) into main (38a2b43) will decrease coverage by 0.11%.
The diff coverage is 28.98%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   58.65%   58.54%   -0.12%     
==========================================
  Files         174      174              
  Lines       17278    17345      +67     
==========================================
+ Hits        10134    10154      +20     
- Misses       7144     7191      +47     

Impacted Files	Coverage Δ
ogre/src/OgreLidarVisual.cc	0.00% <0.00%> (ø)
ogre/src/OgreMarker.cc	0.00% <0.00%> (ø)
ogre2/src/Ogre2Marker.cc	40.88% <0.00%> (-5.22%)	⬇️
ogre2/src/Ogre2LidarVisual.cc	80.67% <35.29%> (-3.18%)	⬇️
ogre2/src/Ogre2DynamicRenderable.cc	75.00% <60.00%> (-0.23%)	⬇️
include/ignition/rendering/base/BaseLidarVisual.hh	84.61% <100.00%> (+0.55%)	⬆️
include/ignition/rendering/base/BaseMarker.hh	51.16% <100.00%> (+7.91%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a2b43...cd65302. Read the comment docs.

[chapulina]

Nice! Can we also make the point size in markers configurable? 🙏

[iche033]

Can we also make the point size in markers configurable?

I created pull request #403 for setting marker point size. I notice that we don't have any gui plugin or msg field to configure the point size though. That may be a good feature to add afterwards.

[adlarkin]

LGTM. I played with the example to change the value passed in to the SetSize call, and things behaved as expected with both ogre and ogre2. When running the example with ogre2, I saw the Error casting user data: Unexpected index message, but this went away when I tested the example with #396.

I left a few minor comments, and wouldn't mind having one more person take a look at this to confirm that the usage of materials/shaders here is okay.

[adlarkin]

As I mentioned before, it'd be nice to have at least one more set of eyes on this since my rendering knowledge is still fairly elementary. But, from what I tested/reviewed, LGTM!