Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added macos instructions #448

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Added macos instructions #448

merged 5 commits into from
Oct 6, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 1, 2021

Signed-off-by: Alejandro Hernández [email protected]

🦟 Bug fix

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde
Added macos instructions
e2a92c9 
Signed-off-by: Alejandro Hernández <[email protected]>
@ahcorde ahcorde requested a review from iche033 October 1, 2021 09:15
@ahcorde ahcorde self-assigned this Oct 1, 2021
@ahcorde ahcorde mentioned this pull request Oct 1, 2021
Closed
13 tasks
@codecov
Copy link

codecov bot commented Oct 1, 2021 •
edited
Loading

Codecov Report

Merging #448 (5353e98) into ign-rendering6 (f93c796) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #448   +/-   ##
===============================================
  Coverage           53.49%   53.49%           
===============================================
  Files                 192      192           
  Lines               19560    19560           
===============================================
  Hits                10464    10464           
  Misses               9096     9096

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93c796...5353e98. Read the comment docs.

@iche033 iche033 added the 🏯 fortress Ignition Fortress label Oct 1, 2021
iche033
iche033 reviewed Oct 1, 2021
View reviewed changes
tutorials/02_install.md Outdated
brew tap osrf/simulation
```

Install Ignition GUI:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI -> Rendering

@ahcorde ahcorde enabled auto-merge (squash) October 4, 2021 07:36
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 4, 2021

@osrf-jenkins retest this please

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 6, 2021

@iche033 can we merge this ?

@iche033 iche033 disabled auto-merge October 6, 2021 16:56
@iche033
Copy link
Contributor

iche033 commented Oct 6, 2021

merging!

@iche033 iche033 merged commit e17fafd into ign-rendering6 Oct 6, 2021
@iche033 iche033 deleted the ahcorde/install/macos branch October 6, 2021 16:57
srmainwaring pushed a commit to srmainwaring/gz-rendering that referenced this pull request Oct 21, 2021
@ahcorde @iche033 @srmainwaring
Added macos instructions (gazebosim#448)
ce520dc 
* Added macos instructions

Signed-off-by: Alejandro Hernández <[email protected]>

* Fix

Signed-off-by: Alejandro Hernández <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
WilliamLewww pushed a commit to WilliamLewww/ign-rendering that referenced this pull request Dec 7, 2021
@ahcorde @iche033 @WilliamLewww
Added macos instructions (gazebosim#448)
f81785e 
* Added macos instructions

Signed-off-by: Alejandro Hernández <[email protected]>

* Fix

Signed-off-by: Alejandro Hernández <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees

@ahcorde ahcorde

Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @iche033