Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Utils unit test #481

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Fix Utils unit test #481

merged 4 commits into from
Nov 1, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 30, 2021

🦟 Bug fix

Updates the click center pos used in the test. This should fix ogre test on macOs. This patch is part of #446.

There is a check added to skip ogre2 tests because they are failing. That's fixed in #446.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 marked this pull request as draft October 30, 2021 00:27
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Oct 30, 2021
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #481 (936af60) into ign-rendering6 (a0d71f6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #481   +/-   ##
===============================================
  Coverage           53.57%   53.58%           
===============================================
  Files                 194      194           
  Lines               19634    19634           
===============================================
+ Hits                10519    10520    +1     
+ Misses               9115     9114    -1     
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d71f6...936af60. Read the comment docs.

@iche033 iche033 marked this pull request as ready for review October 30, 2021 01:21
@iche033 iche033 mentioned this pull request Oct 30, 2021
@ahcorde
Copy link
Contributor

ahcorde commented Nov 1, 2021

ABI checker is complaining, but this PR cannot break ABI

@iche033 iche033 merged commit bfb22fb into ign-rendering6 Nov 1, 2021
@iche033 iche033 deleted the fix_util_test branch November 1, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants