[Metal] Fix depth camera sensor #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default params for fragment shaders in depth camera and selection buffer materials Signed-off-by: Rhys Mainwaring <[email protected]>
8 tasks
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #535 +/- ##
===============================================
Coverage 54.39% 54.39%
===============================================
Files 198 198
Lines 20087 20087
===============================================
Hits 10926 10926
Misses 9161 9161 Continue to review full report at Codecov.
|
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Follow up to #498
Summary
This fix adds default parameters to the Metal fragment shader definitions in the depth camera and selection buffer materials.
A depth camera would not render correctly (black screen) on macOS using Metal shaders. This can be reproduced either using the
depth_cameraexample or by including a depth_camera sensor in a SDF model and displaying the image in Gazebo.After the PR the
depth_cameraexample and Image display are working correctly.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.