Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Windows instructions #116

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Improved Windows instructions #116

merged 2 commits into from
Mar 30, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 29, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Improved Windows instructions and I made some changes to compile the examples on Windows

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from iche033 as a code owner March 29, 2021 13:52
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #116 (80e4e8f) into main (c0dc0e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   76.13%   76.13%           
=======================================
  Files          23       23           
  Lines        2388     2388           
=======================================
  Hits         1818     1818           
  Misses        570      570           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc0e7...80e4e8f. Read the comment docs.

@chapulina chapulina added documentation Improvements or additions to documentation Windows Windows support labels Mar 29, 2021
@chapulina chapulina self-requested a review March 29, 2021 16:11
@chapulina chapulina merged commit 8605a3a into main Mar 30, 2021
@chapulina chapulina deleted the ahcorde/windows/doc branch March 30, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants