Triggered Camera #194
Merged
Triggered Camera #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
scpeters
reviewed
Feb 10, 2022
ahcorde
requested changes
Feb 10, 2022
chapulina
added
the
needs upstream release
WilliamLewww
force-pushed
the
wlew/camera_trigger
branch
from
17ce042 to
80ddf5b
Compare
7 tasks
This was referenced Mar 10, 2022
|
Waiting for pre-release for integration tests: |
ahcorde
requested changes
Mar 11, 2022
ahcorde
requested changes
Mar 11, 2022
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
WilliamLewww
force-pushed
the
wlew/camera_trigger
branch
2 times, most recently
from
c4b4fe8 to
e29a80b
Compare
Signed-off-by: William Lew <[email protected]>
…sors into wlew/camera_trigger
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
ahcorde
requested changes
Mar 29, 2022
Signed-off-by: William Lew <[email protected]>
ahcorde
approved these changes
Mar 29, 2022
|
@osrf-jenkins run tests por favor |
Signed-off-by: William Lew <[email protected]>
…sors into wlew/camera_trigger
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #194 +/- ##
================================================
- Coverage 72.91% 72.55% -0.36%
================================================
Files 33 33
Lines 3075 3094 +19
================================================
+ Hits 2242 2245 +3
- Misses 833 849 +16
Continue to review full report at Codecov.
|
chapulina
removed
the
needs upstream release
scpeters
reviewed
Apr 8, 2022
|
|
||
| using namespace std::chrono_literals; | ||
|
|
||
| class CameraSensorTest: public testing::Test, |
There was a problem hiding this comment.
nit: this should be renamed to TriggeredCameraTest to distinguish it from the tests in test/integration/camera.cc
|
the triggered camera test failed on homebrew CI |
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Triggered Camera
Depends on:
Reference issue:
Test it
Checkout the branch wlew/camera_trigger (ign-gazebo)
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.