Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Distortion / noise render pass is null before setting it #211

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 30, 2022

🦟 Bug fix

The distortion / noise model pointer returned could be null because ign-rendering does not support it.

For example, distortion is supported in ogre 1.x but not ogre 2.x. So when ign-gazebo tries to load an ogre 2.x scene with camera distortion, it'll lead to a crash

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 30, 2022
@iche033 iche033 requested a review from WilliamLewww March 30, 2022 21:50
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #211 (edd0079) into ign-sensors6 (836c306) will decrease coverage by 0.15%.
The diff coverage is 12.50%.

@@               Coverage Diff                @@
##           ign-sensors6     #211      +/-   ##
================================================
- Coverage         73.06%   72.91%   -0.16%     
================================================
  Files                33       33              
  Lines              3067     3075       +8     
================================================
+ Hits               2241     2242       +1     
- Misses              826      833       +7     
Impacted Files Coverage Δ
src/ImageBrownDistortionModel.cc 0.00% <0.00%> (ø)
src/ImageGaussianNoiseModel.cc 73.52% <25.00%> (-6.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836c306...edd0079. Read the comment docs.

@iche033 iche033 merged commit eab2c87 into ign-sensors6 Mar 31, 2022
@iche033 iche033 deleted the render_pass_check branch March 31, 2022 01:37
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants