Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you sure it's unusable with Github? #75

Open
josephernest opened this issue Dec 15, 2020 · 3 comments
Open

Are you sure it's unusable with Github? #75

josephernest opened this issue Dec 15, 2020 · 3 comments

Comments

@josephernest
Copy link

I see you removed Github from the possible applications: 6acd862

Probably because README.md images are agressively "cached".

But they surely is a solution: many repos have "badge" images, that are frequently updated. So with the appropriate caching setting, couldn't it be possible to track with a pixel the page views? See @bkeepers 's comment github/markup#224 (comment):

We're pretty confident that the image caching works. If you're having issues with something like a CI badge, make sure the image has the Cache-Control: no-cache header, and either Expires, Last-Modified or Etag. See the Fastly documentation for more info. If you're still having issues, contact [email protected]

@Yrobot
Copy link

Yrobot commented Apr 20, 2021

I think some part of ga-beacon is unusable now, such as UV.
This is the ga-beacon server logs whan i refresh my repo homepage, you can see cid is different, because the img is requested by the https://camo.githubusercontent.com/ server but client browser. cookie.cid is not working.
image
At least PV works fine.

@Yrobot
Copy link

Yrobot commented Apr 20, 2021

I think some part of ga-beacon is unusable now, such as UV.
This is the ga-beacon server logs whan i refresh my repo homepage, you can see cid is different, because the img is requested by the https://camo.githubusercontent.com/ server but client browser. cookie.cid is not working.
image
At least PV works fine.

which means only Cache-Control, Expires, Last-Modified and Etag will work on github img

@sionsmith
Copy link

Has anyone managed to get this working recently? Or am I just completely wasting my time?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants