Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSHTTR (JULY17) [C++] #207

Closed
wants to merge 5 commits into from
Closed

PSHTTR (JULY17) [C++] #207

wants to merge 5 commits into from

Conversation

taakasj
Copy link

@taakasj taakasj commented Oct 4, 2017 •
edited by Monal5031
Loading

Fixes #204

  • Pull Request Title is of form Problem Code (Contest Code) [Language].
  • This problem already had an entry in this repository.
    • This solution is better than the one already in this repository.
  • This solution is prepared by me and not copied from anywhere else on the web.
  • I have added a copyright comment in my solution.
  • I have updated README.md file (in appropriate order).
  • I have read and followed Code Samples.
  • I understand that pull request will be closed if I failed to update it even once in a week.

@aashutoshrathi
Copy link
Member

Hi! Thanks for contributing to this repository.
Make sure you have checked points in PR correctly.

@taakasj
Copy link
Author

taakasj commented Oct 4, 2017

Do i need to change anything?

@taakasj taakasj mentioned this pull request Oct 4, 2017
Open
7 tasks
@Monal5031 Monal5031 self-assigned this Oct 4, 2017
@Monal5031
Copy link
Member

Monal5031 commented Oct 4, 2017 •
edited
Loading

@taakasj Please update the PR title and description as per rules. Also add entry to readme.

@taakasj taakasj changed the title Added C++ code for PSHTTR problem in july17 PSHTTR (July17) [C++] Oct 4, 2017
@taakasj taakasj changed the title PSHTTR (July17) [C++] PSHTTR (JULY17) [C++] Oct 4, 2017
@taakasj
Copy link
Author

taakasj commented Oct 4, 2017

Is it fine now?

@Monal5031
Copy link
Member

@taakasj Looks like you are using space for indentations but this repo is configured to use tab indentations for c and cpp thats the cause of travil build fail too. Please change the space indentations to tab indentations.

Monal5031
Monal5031 reviewed Oct 4, 2017
View reviewed changes
2017/JULY.md Outdated
@@ -14,7 +14,7 @@
| [JULY17](https://www.codechef.com/JULY17) | [CALC](https://www.codechef.com/JULY17/problems/CALC) | ★★★ | [![image](../img/GH.png)](JULY/JULY17/CALC/CALC.c) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14483078) (100 pts) [![image](../img/AC.png)](#) | [![image](../img/GH.png)](JULY/JULY17/CALC/CALC.cpp) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14439041) (100 pts) [![image](../img/AC.png)](#) | | [![image](../img/GH.png)](JULY/JULY17/CALC/CALC.py) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14490655) (100 pts) [![image](../img/AC.png)](#) |
| [JULY17](https://www.codechef.com/JULY17) | [IPCTRAIN](https://www.codechef.com/JULY17/problems/IPCTRAIN) | ★★★ | | [![image](../img/GH.png)](JULY/JULY17/IPCTRAIN/IPCTRAIN.cpp)  [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14431781) (100 pts) [![image](../img/AC.png)](#) | | |
| [JULY17](https://www.codechef.com/JULY17) | [EXPTREE](https://www.codechef.com/JULY17/problems/EXPTREE) | ★★★★ | | | | [![image](../img/GH.png)](JULY/JULY17/EXPTREE/EXPTREE.py)  [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14541593) (100 pts) [![image](../img/AC.png)](#) |
| [JULY17](https://www.codechef.com/JULY17) | [PSHTTR](https://www.codechef.com/JULY17/problems/PSHTTR) | ★★★★ | | | | |
| [JULY17](https://www.codechef.com/JULY17) | [PSHTTR](https://www.codechef.com/JULY17/problems/PSHTTR) | ★★★★ | | [![image](../img/GH.png)](JULY/JULY17/CALC/CALC.cpp) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14493803) (100 pts) [![image](../img/AC.png)](#)| | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a space after (#)

@taakasj
Copy link
Author

taakasj commented Oct 4, 2017 •
edited
Loading

i am not able to figure out what is going wrong with the travis build. Can u please help?

@DivyeshPuri
Copy link
Collaborator

@taakasj Use tabs instead of spaces and there is inconsistency in indentation too.

@taakasj
Copy link
Author

taakasj commented Oct 6, 2017

For every space in code.

Monal5031
Monal5031 reviewed Oct 7, 2017
View reviewed changes
Copy link
Member

@Monal5031 Monal5031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the changes.

2017/JULY/JULY17/PSHTTR/PSHTTR.cpp
rep(i,0,q) printf("%lld\n",ans[i]);
}
return 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add newline at end.

2017/JULY.md
@@ -14,7 +14,7 @@
| [JULY17](https://www.codechef.com/JULY17) | [CALC](https://www.codechef.com/JULY17/problems/CALC) | ★★★ | [![image](../img/GH.png)](JULY/JULY17/CALC/CALC.c) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14483078) (100 pts) [![image](../img/AC.png)](#) | [![image](../img/GH.png)](JULY/JULY17/CALC/CALC.cpp) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14439041) (100 pts) [![image](../img/AC.png)](#) | | [![image](../img/GH.png)](JULY/JULY17/CALC/CALC.py) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14490655) (100 pts) [![image](../img/AC.png)](#) |
| [JULY17](https://www.codechef.com/JULY17) | [IPCTRAIN](https://www.codechef.com/JULY17/problems/IPCTRAIN) | ★★★ | | [![image](../img/GH.png)](JULY/JULY17/IPCTRAIN/IPCTRAIN.cpp)  [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14431781) (100 pts) [![image](../img/AC.png)](#) | | |
| [JULY17](https://www.codechef.com/JULY17) | [EXPTREE](https://www.codechef.com/JULY17/problems/EXPTREE) | ★★★★ | | | | [![image](../img/GH.png)](JULY/JULY17/EXPTREE/EXPTREE.py)  [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14541593) (100 pts) [![image](../img/AC.png)](#) |
| [JULY17](https://www.codechef.com/JULY17) | [PSHTTR](https://www.codechef.com/JULY17/problems/PSHTTR) | ★★★★ | | | | |
| [JULY17](https://www.codechef.com/JULY17) | [PSHTTR](https://www.codechef.com/JULY17/problems/PSHTTR) | ★★★★ | | [![image](../img/GH.png)](JULY/JULY17/PSHTTR/PSHTTR.cpp) [![image](../img/CC.png)](https://www.codechef.com/viewsolution/14493803) (100 pts) [![image](../img/AC.png)](#) | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use spaces for README and tabs for codes.

@Monal5031 Monal5031 closed this Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monal5031 Monal5031 Monal5031 left review comments

Assignees

@Monal5031 Monal5031

Labels
process/pending_review size/S status/inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PSHTTR (JULY17) [C++]
4 participants
@taakasj @aashutoshrathi @Monal5031 @DivyeshPuri