Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in C# sample code from CONTRIBUTING.md #503

Closed
5 of 7 tasks
DimaMukhin opened this issue Oct 7, 2017 · 4 comments · Fixed by #507
Closed
5 of 7 tasks

Bug in C# sample code from CONTRIBUTING.md #503

DimaMukhin opened this issue Oct 7, 2017 · 4 comments · Fixed by #507

Comments

@DimaMukhin
Copy link
Contributor

This issue is about a bug in the C# sample code from the CONTRIBUTING.md file.

The sample code is wrong for C# and will produce the following error:
"'QuickSort': member names cannot be the same as their enclosing type"
This can be easily fixed by changing the method "QuickSort" into "DoQuickSort"

  • Issue Title is in form Algo/DS Name [Language].
  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This Algo/DS is worth adding to this repository.
  • Assign this issue to me (I want to work on this).
    • I ensure that I am not already assigned to 2 or more issues.
  • I will send my PR only after I'm assigned to this issue by any maintainer.
  • I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.
@singhpratyush
Copy link
Member

The contributors most likely able to help are:

@aashutoshrathi

@singhpratyush
Copy link
Member

@mohitkyadav @aashutoshrathi: Please see if we need to make this change.

@mohitkyadav
Copy link
Member

Yes @singhpratyush this change is needed. @DimaMukhin Please proceed with this issue.

@aashutoshrathi
Copy link
Member

Yes, @singhpratyush this change is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants