Added Binary Search [C++] #550

ishakalra · 2017-10-19T19:40:10Z

Fixes #548

By submitting this pull request I confirm I've read and complied with the below declarations.

I have read the Contribution guidelines and I am confident that my PR reflects them.
I have followed the coding guidelines for this project.
My code follows the skeleton code structure.
This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

singhpratyush · 2017-10-19T22:26:22Z

Hi! Thanks for showing interest in contributing to this repository.

Please make sure that you have ticked the points mentioned in PR description correctly.

Thanks again!

singhpratyush · 2017-10-20T18:05:45Z

@ishakalra: Please fix travis build. Thanks :)

ishakalra · 2017-10-21T17:04:38Z

@singhpratyush Hi, earlier the build failed due to indent spaces/tabs, I tried modifying that but now I can't seem to figure out where the fault is. Would be really grateful if you could guide me through the issue!

mohitkyadav

Please make a new entry in README and see comments

mohitkyadav · 2017-10-21T17:13:43Z

binary_search/binarysearch.cpp

@@ -0,0 +1,38 @@
+#include<iostream>
+using namespace std;


Give a blank line at line 2 and 3.

mohitkyadav · 2017-10-21T17:14:49Z

binary_search/binarysearch.cpp

+#include<iostream>
+using namespace std;
+int binarySearchIterative(int array[], int start, int end, int find)
+{


Please follow Google's C++ style guide. https://google.github.io/styleguide/cppguide.html

mohitkyadav · 2017-10-21T17:15:09Z

binary_search/binarysearch.cpp

+{
+	while(end >= start)
+	{
+		int mid = start + (end - start)/2;


Put space around binary operators.

mohitkyadav · 2017-10-21T17:15:37Z

binary_search/binarysearch.cpp

+	}
+	return -1;
+}
+int binarySearchRecursive(int array[], int start, int end, int find)


Blank line at line 17.

mohitkyadav · 2017-10-21T17:15:59Z

binary_search/binarysearch.cpp

+	int array[] = { 1, 2, 3, 4, 5, 6, 11, 23, 25, 66, 88, 99, 113 };
+	int end = sizeof(array)/sizeof(array[0]);
+	cout<<binarySearchIterative(array,0,end,1)<<'\n'<<binarySearchRecursive(array,0,end,1)<<'\n';
+	cout<<binarySearchIterative(array,0,end,0)<<'\n'<<binarySearchRecursive(array,0,end,0)<<'\n';


Put space around <<.

Monal5031 · 2017-10-21T21:59:11Z

binary_search/binarysearch.cpp

+	int end = sizeof(array)/sizeof(array[0]);
+	cout<<binarySearchIterative(array,0,end,1)<<'\n'<<binarySearchRecursive(array,0,end,1)<<'\n';
+	cout<<binarySearchIterative(array,0,end,0)<<'\n'<<binarySearchRecursive(array,0,end,0)<<'\n';
+	return 1;


@ishakalra Try returning 0 here, let's see if the build is fixed.

Monal5031

Please make the following changes.

Monal5031 · 2017-10-21T22:00:43Z

binary_search/binarysearch.cpp

@@ -0,0 +1,38 @@
+#include<iostream>
+using namespace std;
+int binarySearchIterative(int array[], int start, int end, int find)


Use underscores for naming variables and functions instead of camelCase in whole code.

singhpratyush · 2017-10-25T11:34:30Z

@ishakalra: The indentation is good now. The issue is due to non zero return code by the main method. Travis build would be fixed after making it return 0.

main method now returns 0.

singhpratyush · 2017-10-25T14:31:06Z

The build is now fixed 🎉. Please take a look at comments from @mohitkyadav and @Monal5031 and make if needed.

Used underscores in place of camelCases, added spaces and blank lines.

Monal5031

@ishakalra Some minor changes left in code indentations, code looks good otherwise 👍

Monal5031 · 2017-10-30T08:21:41Z

binary_search/binarysearch.cpp

+using namespace std;
+
+int binary_search_iterative(int array[], int start, int end, int find)
+{


The indentation is not according to standard cpp guidelines.
The opening curly brace always starts in same line.
int name_of_func(...) { Same changes in rest of the file.

Monal5031 · 2017-10-30T08:22:08Z

binary_search/binarysearch.cpp

+
+int binary_search_iterative(int array[], int start, int end, int find)
+{
+	while(end >= start)


Please make this, while (...) { as per standard cpp guidelines. Same changes in rest of the file.

Monal5031 · 2017-10-30T08:22:27Z

binary_search/binarysearch.cpp

+	{
+		int mid = start + (end - start)/2;
+		if(array[mid] == find)
+			return mid;


Add whitespace around binary operator /. Same changes in rest of the file.

Monal5031 · 2017-10-30T08:22:41Z

binary_search/binarysearch.cpp

+		int mid = start + (end - start)/2;
+		if(array[mid] == find)
+			return mid;
+		else if(array[mid] < find)


else if (...) { Same changes in rest of the file.

Monal5031 · 2017-10-30T08:22:50Z

binary_search/binarysearch.cpp

+	while(end >= start)
+	{
+		int mid = start + (end - start)/2;
+		if(array[mid] == find)


if (...) { Same changes in rest of the file.

Added Binary Search [C++]

56cfef3

singhpratyush added Algorithm Hacktoberfest lang-cpp labels Oct 20, 2017

Updated Binary Search [C++]

f65cf98

mohitkyadav requested changes Oct 21, 2017

View reviewed changes

Monal5031 reviewed Oct 21, 2017

View reviewed changes

Monal5031 requested changes Oct 21, 2017

View reviewed changes

Update iiitv#2

8922b10

main method now returns 0.

singhpratyush added the test/PASSING label Oct 25, 2017

singhpratyush added test/PASSING and removed test/PASSING labels Oct 25, 2017

Added requested changes

1b429db

Used underscores in place of camelCases, added spaces and blank lines.

singhpratyush added test/PASSING and removed test/PASSING labels Oct 28, 2017

Monal5031 requested changes Oct 30, 2017

View reviewed changes

singhpratyush added the No activity label Nov 16, 2017

singhpratyush closed this Jan 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Binary Search [C++] #550

Added Binary Search [C++] #550

ishakalra commented Oct 19, 2017 •

edited by Monal5031

Loading

singhpratyush commented Oct 19, 2017

singhpratyush commented Oct 20, 2017

ishakalra commented Oct 21, 2017

mohitkyadav left a comment

mohitkyadav Oct 21, 2017

mohitkyadav Oct 21, 2017

mohitkyadav Oct 21, 2017

mohitkyadav Oct 21, 2017

mohitkyadav Oct 21, 2017

Monal5031 Oct 21, 2017

Monal5031 left a comment

Monal5031 Oct 21, 2017

singhpratyush commented Oct 25, 2017

singhpratyush commented Oct 25, 2017

Monal5031 left a comment •

edited

Loading

Monal5031 Oct 30, 2017

Monal5031 Oct 30, 2017

Monal5031 Oct 30, 2017

Monal5031 Oct 30, 2017

Monal5031 Oct 30, 2017

Added Binary Search [C++] #550

Added Binary Search [C++] #550

Conversation

ishakalra commented Oct 19, 2017 • edited by Monal5031 Loading

By submitting this pull request I confirm I've read and complied with the below declarations.

singhpratyush commented Oct 19, 2017

singhpratyush commented Oct 20, 2017

ishakalra commented Oct 21, 2017

mohitkyadav left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monal5031 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

singhpratyush commented Oct 25, 2017

singhpratyush commented Oct 25, 2017

Monal5031 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishakalra commented Oct 19, 2017 •

edited by Monal5031

Loading

Monal5031 left a comment •

edited

Loading