Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppStaticStorage & django 1.9 #7

Open
llaisdy opened this issue May 24, 2016 · 3 comments
Open

AppStaticStorage & django 1.9 #7

llaisdy opened this issue May 24, 2016 · 3 comments

Comments

@llaisdy
Copy link

llaisdy commented May 24, 2016

Dear All

I'm interested in using django_layers with django 1.9.

Although the commit log implies django 1.9 is supported, finders.py imports AppStaticStorage (from django.contrib.staticfiles.storage), which was removed in django 1.7 --- and (for me at least) this file raises an error with django 1.9

Are you using django_layers with django 1.9? If so, how are you avoiding this error?

In the meantime I shall look into what happened to AppStaticStorage and how to replace it in finders.py. I'll submit a PR if I make progress.

With thanks and best wishes

Ivan

@yoanisgil
Copy link

@llaisdy I implemented a couple of tweaks here:

https://github.com/yoanisgil/django_layers/tree/django-1.7

to make django_layers work with Django 1.7, so it might help you to get in the right track for implementing Django 1.9 compatibility.

@llaisdy
Copy link
Author

llaisdy commented May 24, 2016

Thanks! That looks like just what I was looking for. I'll report back later today.

@llaisdy
Copy link
Author

llaisdy commented May 24, 2016

Thanks v much. Now working. I pulled over your AppStatic->StaticFile change in finders.py, and updated some imports in the same module. I'll do a PR just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants