From d4666d9aa5df7e6db6657c7a448761a071b637b3 Mon Sep 17 00:00:00 2001 From: James Wang Date: Sun, 8 Dec 2019 21:27:32 -0600 Subject: [PATCH] Remove unused `shouldCheckFeedback` parameter (#299) * Remove unused `shouldCheckFeedback` parameter * Update CHANGELOG * Remove unused eslint rule disable --- CHANGELOG.md | 1 + src/containers/QuestionListContainer.js | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 46fe9b5f..fde5a829 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ When a new version is tagged, the changes since the last deploy should be labele with the current semantic version and the next changes should go under a **[Next]** header. ## [Next] +* Fix question feedback submission. ([@james9909](https://github.com/jamse9909) in [#299](https://github.com/illinois/queue/pull/29)) ## v1.4.0 * Created a course settings page, which allows for unlisted courses and removal of the question feedback modal. ([@rittikaadhikari](https://github.com/rittikaadhikari) in [#293](https://github.com/illinois/queue/pull/293)) diff --git a/src/containers/QuestionListContainer.js b/src/containers/QuestionListContainer.js index 0ba2ff2a..f2b7bac0 100644 --- a/src/containers/QuestionListContainer.js +++ b/src/containers/QuestionListContainer.js @@ -32,14 +32,11 @@ const mapStateToProps = (state, props) => ({ const mapDispatchToProps = (dispatch, { queueId }) => ({ fetchQuestions: () => dispatch(fetchQuestions(queueId)), deleteQuestion: questionId => dispatch(deleteQuestion(queueId, questionId)), - // eslint-disable-next-line max-len updateQuestionBeingAnswered: (questionId, beingAnswered) => dispatch(updateQuestionAnswering(questionId, beingAnswered)), - // eslint-disable-next-line max-len updateQuestion: (questionId, attributes) => dispatch(updateQuestion(questionId, attributes)), - // eslint-disable-next-line max-len - finishAnsweringQuestion: (questionId, shouldCheckFeedback, feedback) => + finishAnsweringQuestion: (questionId, feedback) => dispatch(finishAnsweringQuestion(queueId, questionId, feedback)), })