Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN #391

Merged
merged 3 commits into from
Oct 26, 2018
Merged

zh-CN #391

merged 3 commits into from
Oct 26, 2018

Conversation

YuechengWu
Copy link

@YuechengWu YuechengWu commented Oct 26, 2018

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the dev branch. Also you should start your branch off dev branch.
  • Check you have added tests that prove your fix is effective or that your feature works.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you added any notable changes to the CHANGELOG.md file.

Description

Please describe your pull request.

  • added simplified Chinese translation

💔Thank you!

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #391 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #391   +/-   ##
=========================================
  Coverage     82.21%   82.21%           
  Complexity      319      319           
=========================================
  Files           106      106           
  Lines          1012     1012           
=========================================
  Hits            832      832           
  Misses          180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299fa56...0d1e7a8. Read the comment docs.

@Hasnayeen
Copy link
Owner

@YuechengWu thanks for the translation

@Hasnayeen Hasnayeen merged commit 1ee32f2 into Hasnayeen:dev Oct 26, 2018
@YuechengWu
Copy link
Author

@Hasnayeen, you are welcome, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants