Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand support for "executable" accessory files #109

Open
hinerm opened this issue May 17, 2024 · 5 comments
Open

Expand support for "executable" accessory files #109

hinerm opened this issue May 17, 2024 · 5 comments

Comments

@hinerm
Copy link
Member

hinerm commented May 17, 2024

Currently, executable files are treated specially and directly downloaded: they bypass the update subdirectory when installing, and an .old copy is created to signify deletion.

With Jaunch we now have necessary toml accessory files that are required for the launcher to work. This means they should be treated the same way by the launcher: bypassing the update directory and with a .old copy.

Basically, if we're checking for executable we should probably check if it's a toml file, as well.

This is one key location, but there are almost certainly others that need updating as well.

@hinerm
Copy link
Member Author

hinerm commented May 17, 2024

Note that a temporary hack can be done on the update site side, by manually adding executable = "true" to the toml entries in the db.xml.gz

@hinerm
Copy link
Member Author

hinerm commented May 17, 2024

note that the Props.class (and .java?) file(s) are also needed

@ctrueden
Copy link
Member

Thanks @hinerm. About Props.java: it is not needed.

@hinerm
Copy link
Member Author

hinerm commented May 17, 2024

Ah there's just a warning about Props being missing. I didn't realize that I was not able to upload it even with my changes

@ctrueden
Copy link
Member

On POSIX-friendly systems: is the executable bit of the file used to discern whether the file should be marked "executable" in the DB? And on Windows: does it use the .exe extension to decide?

And conversely: when installing an "executable" file from an update site, does the Updater set the executable bit on those files on POSIX-friendly systems? If so, that means the TOML files will be marked +x, which is suboptimal. Tolerable as a hack, yeah, but it would be nice not to conflate the two related-but-distinct ideas of "executable" and "part of the launcher machinery".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants