Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasionally localized strings do not load/display #685

Closed
AsgardXIV opened this issue Dec 13, 2021 · 1 comment
Closed

Occasionally localized strings do not load/display #685

AsgardXIV opened this issue Dec 13, 2021 · 1 comment

Comments

@AsgardXIV
Copy link
Contributor

AsgardXIV commented Dec 13, 2021

Describe the bug
Occasionally localized strings do not load correctly. It is most obvious when you hover over the shortcuts when loading Appearances/Poses, they will randomly have the Label or not.

I believe I have a fix for this linked below.

To Reproduce
Steps to reproduce the behaviour:

  1. Open Anamnesis
  2. Go to load appearance and hover over the shortcuts, some will not have a label randomly.

Expected behaviour
The labels should appear.

More Info
I've submitted a fix to XivToolsWpf which appears to resolve this at XIV-Tools/XivToolsWpf#2 - it seems to be a race condition fetching the locale manager.
Please let me know if you need any more info.

Before:
Missing

After:
Working

@AsgardXIV AsgardXIV changed the title Occasionally Localized Strings do not appear Occasionally localized Strings do not load/display Dec 13, 2021
@AsgardXIV AsgardXIV changed the title Occasionally localized Strings do not load/display Occasionally localized strings do not load/display Dec 13, 2021
@Yuki-Codes
Copy link
Contributor

Fix has been merged and included for next release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants