Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Weapon Visibility not working #899

Closed
nyanyastudio opened this issue Mar 26, 2022 · 7 comments · Fixed by #903
Closed

Toggle Weapon Visibility not working #899

nyanyastudio opened this issue Mar 26, 2022 · 7 comments · Fixed by #903
Labels
Bug Something isn't working Investigate Targeting

Comments

@nyanyastudio
Copy link

Describe the bug
Toggle Weapon Visibility not working

To Reproduce
Steps to reproduce the behaviour:

  1. Add weapon to main/off-hand slot
  2. Enter Gpose (or stay outside)
  3. Click "Toggle Weapon Visibility"

Expected behaviour
Before the latest update the toggle would work in and outside of Gpose. Albeit the weapon would reappear if you hid it before entering Gpose (and then entered).

Apologies if this was already reported or if I'm just doing it wrong. Couldn't find anything on the topic.

@Luminiari Luminiari added Bug Something isn't working Targeting Investigate labels Mar 26, 2022
@AsgardXIV
Copy link
Contributor

AsgardXIV commented Mar 26, 2022

Is the weapon drawn when you are doing this? You need to set the scale to 0.

In the previous version of Ana, the toggle would just set the scale to 0, in the new version it follows the same rules as if you toggle it in the character menu, so it will be invisible when sheathed and visible when drawn.

If you want to hide a drawn weapon, set the scale to 0 as shown below.

image

@nyanyastudio
Copy link
Author

Is the weapon drawn when you are doing this? You need to set the scale to 0.

In the previous version of Ana, the toggle would just set the scale to 0, in the new version it follows the same rules as if you toggle it in the character menu, so it will be invisible when sheathed and visible when drawn.

If you want to hide a drawn weapon, set the scale to 0 as shown below.

image

Oh I know I know, scaling still works fine. It's not a major issue, it just makes the toggle obsolete since it just doesn't do anything at all.

But to clarify what I'm doing, here's a video. Before this would hide the weapon the same as scaling it to 0 would. Now it's just... nothing?

@AsgardXIV
Copy link
Contributor

AsgardXIV commented Mar 26, 2022

It's because you have the weapon actually drawn. If it was sheathed at your side it would hide/show it, just like the toggle in game (So if you had it hidden in game, it would show it. which scale can't do).

It behaves identically to the toggle on your character window, but works for other players as well (and within GPose).

@nyanyastudio
Copy link
Author

It's because you have the weapon actually drawn. If it was sheathed at your side it would hide/show it, just like the toggle in game (So if you had it hidden in game, it would show it. which scale can't do).

Aahhh fair enough

@AsgardXIV
Copy link
Contributor

Not sure if Yuki or Ani maybe has an idea about how to improve the UI around it (Have 2 toggles or similar).

@Yuki-Codes
Copy link
Contributor

can we detect if the weapon is drawn? we could swap out the toggle functionality for scale at the time? Trying to avoid having 2 toggle buttons on the UI for the same task again.

@Yuki-Codes
Copy link
Contributor

(github auto closed this, but its not fixed yet)

Now that we have the IsSheathed, I can update the UI to have the toggle swap out for the old scale one when the weapon is drawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Investigate Targeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants