Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be a vrdisplaypresenterror event? #109

Closed
cvan opened this issue Oct 13, 2016 · 2 comments
Closed

Should there be a vrdisplaypresenterror event? #109

cvan opened this issue Oct 13, 2016 · 2 comments

Comments

@cvan
Copy link
Contributor

cvan commented Oct 13, 2016

For measure, the Fullscreen API has the following events:

For the WebVR API, we have

If someone calls vrDisplay.requestPresent() and it rejects (or possibly if it throws too), I would hope for an event to fire. Otherwise, I'll have to rely on Promises entirely and interface with these methods directly, at which point the events become not that useful.

@toji
Copy link
Member

toji commented Oct 13, 2016

To be honest I'd prefer to reply on the promise entirely, but that's not a viable option for vrdisplaypresentchange. The issue is that the browser may force you our of VR presentation at any time for any reason (most likely the user hit some explicit "Exit WebVR" button, like tapping esc to exit fullscreen). We can add an error event, certainly, but I don't see it filling an explicit need like the presentchange event does.

@toji toji closed this as completed Jan 11, 2017
@toji
Copy link
Member

toji commented Jan 11, 2017

Brought this up at the WebVR F2F in Kirkland. Room agreed with assessment above. Closing as will not implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants