Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VRDisplayCapabilities#canPresent to be less ambiguous for detecting "magic window" #182

Closed
cvan opened this issue Jan 28, 2017 · 2 comments

Comments

@cvan
Copy link
Contributor

cvan commented Jan 28, 2017

IMO, <VRDisplay>.capabilities.canPresent seems a bit odd (to be a property of the capabilities object and the canPresent naming).

perhaps instead have <VRDisplay>.isRealDisplay (à la OpenVR's IsDisplayRealDisplay)?

@cvan cvan changed the title Rename VRDisplayCapabilities#canPresent to be less ambiguous Rename VRDisplayCapabilities#canPresent to be less ambiguous for detecting "magic window" Jan 28, 2017
@toji
Copy link
Member

toji commented Mar 16, 2017

@cvan knows this, but for the benefit of anyone else: The proposal for 2.0 here is that you attempt to create an exclusive (presenting) or non-exclusive (magic window) context, and the implementation can fail in either case. There's also a supportsSession function for testing if the given session type is supported without actually creating one. That should generally solve the issue of this being an awkward capability bit.

@toji toji closed this as completed Mar 16, 2017
@cvan
Copy link
Contributor Author

cvan commented Mar 17, 2017

yeah, this seems good - thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants