Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool should check for max idle lifetime in cleaner #58

Open
Sytten opened this issue Jun 18, 2021 · 0 comments
Open

Pool should check for max idle lifetime in cleaner #58

Sytten opened this issue Jun 18, 2021 · 0 comments

Comments

@Sytten
Copy link
Collaborator

Sytten commented Jun 18, 2021

Currently the idle lifetime is only checked when the connection is requested.
It should also be checked by the cleaner.
Imagine the following scenario:

  • You have a low idle lifetime but no max lifetime
  • You have a rush of load on your system, the pool lends a bunch of connections
  • Your system returns to normal load
  • The connections are never freed because nobody request them
    This is the situation faced by issue with connection pool ? prisma/prisma#7644

I will push a fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant