-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developing ts-protoc-gen on windows #79
Comments
Hey, sorry as you can probably guess I'm not a Windows user 😂 I think having a Windows build would make it easier for others to contribute to the project so would be in favour. Personally I'd be in favour of your third suggestion, replacing the shell scripts with node scripts as this way we are less likely to regress a build system in future |
Thanks for raising this! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I've got a local branch where I'm working on a replacement to |
@jonnyreeves - Just curious. Is this dead? |
It would appear that all bash scripts and use of linux commands were "fixed" by @esilkensen in #193. I'm going to resolve this issue now - please open a new one if there are any outstanding blockers to developing within a Windows environment. |
The use of sh files, and especially calling the protoc-gen-ts (uses
#!/usr/bin/env node
to execute), from generate.sh makes it really hard to run the scripts on windows. (e.g.generate.bat
). Even when running Cygwin or msysI've messed around with making cmd proxies and whatnot, as well as detecting the system on windows manually in the sh file, but i'd rather ask: Is building on windows going to be supported?
If not, that's ok. I've spent the evening installing Windows Subsystem for Linux and that seems to have done it. The readme could clarify that this is the way to go.
If yes, what's the approach you'd like to take in order to allow running scripts on windows?
I see three options, but there may be more available:
Once you decide, I'd be happy to make a pr.
The text was updated successfully, but these errors were encountered: