Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Need async_push_notification #172

Closed
boboxiaodd opened this issue May 22, 2017 · 3 comments
Closed

V2 Need async_push_notification #172

boboxiaodd opened this issue May 22, 2017 · 3 comments

Comments

@boboxiaodd
Copy link

boboxiaodd commented May 22, 2017

i use v2
i found the push_notification is sync mode,
Even if you use spawn, sending multiple notifications at the same time can be delayed

@boboxiaodd boboxiaodd changed the title Need async_push_notification V2 Need async_push_notification May 22, 2017
@ferigis
Copy link
Member

ferigis commented May 22, 2017

Hi @boboxiaodd. Thanks for using our library.
We did it synchronous because every HTTP2 request to APNs servers has a response. Did you try opening many connections and balancing the requests between them?
This is what Apple says about that:
You can establish multiple connections to APNs servers to improve performance. When you send a large number of remote notifications, distribute them across connections to several server endpoints. This improves performance, compared to using a single connection, by letting you send remote notifications faster and by letting APNs deliver them faster.

@boboxiaodd
Copy link
Author

Thank you! i try to make a pool connections to apns ,and push_notification with random connection.

@ferigis
Copy link
Member

ferigis commented May 22, 2017

@boboxiaodd your welcome.
If you are thinking about a pool, maybe you could take a look on worker_pool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants