Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apns:close_connection don't closed h2_connect #209

Closed
boboxiaodd opened this issue Mar 9, 2018 · 2 comments
Closed

apns:close_connection don't closed h2_connect #209

boboxiaodd opened this issue Mar 9, 2018 · 2 comments
Assignees

Comments

@boboxiaodd
Copy link

boboxiaodd commented Mar 9, 2018

handle_cast(stop, State) ->

i modify apns_connect.erl and fixed this issues.

handle_cast(stop,  #{http2_connection := HTTP2Conn} = State) ->
   h2_client:stop(HTTP2Conn),
   {stop, normal, State};

by the way , i use chatterbox 0.7.0 ,and it replace gen_fsm to gen_statem

@ferigis
Copy link
Member

ferigis commented Mar 9, 2018

Hi @boboxiaodd , thanks for the fix. Could you please raise a PR with your fix?

@boboxiaodd
Copy link
Author

sorry @ferigis i don't know how to do it.
i use apns:close_connection every 10min ,and use apns:connect a new h2_connect
to solve chatterbox's memory leak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants