Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get riak store to return the number of deleted rows in sumo:delete_by() #204

Closed
davecaos opened this issue Oct 8, 2015 · 4 comments
Closed
Labels

Comments

@davecaos
Copy link

davecaos commented Oct 8, 2015

No description provided.

@davecaos davecaos added the bug label Oct 8, 2015
@elbrujohalcon elbrujohalcon changed the title Made in riak store sumo:find_by() function returns the number of deleted rows Get riak store to return the number of deleted rows in sumo:find_by() Nov 9, 2015
@elbrujohalcon elbrujohalcon changed the title Get riak store to return the number of deleted rows in sumo:find_by() Get riak store to return the number of deleted rows in sumo:delete_by() Nov 9, 2015
@cabol
Copy link
Contributor

cabol commented Feb 11, 2016

Actually sumo_store_riak:delete_by/2 is returning the number of deleted docs: https://github.com/inaka/sumo_db/blob/master/src/sumo_store_riak.erl#L129.

So, @elbrujohalcon should we close this issue?

@elbrujohalcon
Copy link
Member

If there's a test and it is evaluated for the riak store (among others) and it passes, then yes, @cabol

@cabol
Copy link
Contributor

cabol commented Feb 11, 2016

Yes we're testing it, E.g.: https://github.com/inaka/sumo_db/blob/master/test/sumo_basic_SUITE.erl#L132

PD: In fact, thanks to this test we discovered an issue with sumo_store_mongo:delete_by/2, which is not returning the total of deleted docs (issue #225). BTW, it was fixed already.

@elbrujohalcon
Copy link
Member

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants