Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-native-inat-camera with react-native-vision-camera #529

Closed
kueda opened this issue Nov 2, 2022 · 2 comments
Closed

Replace react-native-inat-camera with react-native-vision-camera #529

kueda opened this issue Nov 2, 2022 · 2 comments
Assignees
Labels
android enhancement New feature or request performance Will improve performance of the app

Comments

@kueda
Copy link
Member

kueda commented Nov 2, 2022

react-native-inat-camera is our own custom camera library with native camera implementations. It works pretty well in iOS, but has some pretty serious performance problems on Android. We made it because at the time there wasn't a good React Native camera library that could use the kinds of ML models we use. Since then react-native-vision-camera has added support for custom frame processors, which is exactly the kind of hook we need to do custom classification with that camera. That library supports more recent camera SDKs on Android and might provide a better camera experience. FWIW, @budowski has made a proof-of-concept showing that we can use that technique to use our model with react-native-vision-camera.

The task here is to replace react-native-inat-camera in Seek with react-native-vision-camera with a custom frame processor, and determine if the experience on Android is superior to our custom camera, and the experience on iOS is no different (or better). So kind of R&D that will hopefully make it into the product. Yaron has done the most work on this so if he's not the one to work on this issue, whoever is should check in with him to get his proof-of-concept code.

@kueda kueda added enhancement New feature or request performance Will improve performance of the app labels Nov 2, 2022
@jtklein
Copy link
Contributor

jtklein commented Jul 4, 2023

Some leftover TODOs:

  • Fix bug where taxon on match screen jumps between different values.
  • Fix: photos taken with rotated device are shown rotated on the match screen

@jtklein jtklein added the android label Jul 5, 2023
@jtklein
Copy link
Contributor

jtklein commented Jul 5, 2023

Scoping this to be Android only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android enhancement New feature or request performance Will improve performance of the app
Projects
None yet
Development

No branches or pull requests

2 participants