Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noise for empty-signature in export #361

Closed
FantasticoFox opened this issue May 1, 2024 · 8 comments
Closed

Reduce noise for empty-signature in export #361

FantasticoFox opened this issue May 1, 2024 · 8 comments

Comments

@FantasticoFox
Copy link
Collaborator

{
"signature": null, // instead of object with all empty strings
}

This helps us to keep the code clean on the guardian side. Please help us to iterate through the different aspects of the output to reduce it to minimum.

@FantasticoFox
Copy link
Collaborator Author

null signature was reverted as it was buggy.

@FantasticoFox
Copy link
Collaborator Author

Current export of the default main page after deployment:

image

Expected output, important if its genesis revision it should also hold a null value.

image

@FantasticoFox
Copy link
Collaborator Author

Verifier has been updated to support null value inblockio/aqua-verifier-js#21

@it-spiderman
Copy link
Collaborator

it-spiderman commented May 23, 2024

Done in #374 => @FantasticoFox

Export/import in PKC works.
However, i could not test with extenal verifier, as i dont know how to get this patch into my extension
inblockio/aqua-verifier-js#21

I tried removing and re-installing the Chrome ext, but didnt help
With this patch, verifier should presumably work, but needs to be tested before PR is merged

@FantasticoFox
Copy link
Collaborator Author

Please check with the current release 1.2.6 which supports the null value.
https://chromewebstore.google.com/detail/verifypage/gadnjidhhadchnegnpadkibmjlgihiaj?hl=en-GB

@FantasticoFox
Copy link
Collaborator Author

I tested it and it works fine with the current VerifyPage release. Thank you.

@FantasticoFox
Copy link
Collaborator Author

Re-open due to #376

@it-spiderman
Copy link
Collaborator

To be closed when #376 is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants