Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing soname bump in zebra 2.2.1 #22

Closed
hughmcmaster opened this issue Nov 2, 2020 · 7 comments
Closed

Missing soname bump in zebra 2.2.1 #22

hughmcmaster opened this issue Nov 2, 2020 · 7 comments

Comments

@hughmcmaster
Copy link
Contributor

When fixing #12, four instances/symbols were removed. This is a breaking ABI change and should have resulted in a soname/soversion bump in 2.2.1.

I missed this at the time.

ZEBRALIBS_VERSION_INFO=0:1:0

This should now be ZEBRALIBS_VERSION_INFO=1:0:0.

To maintain library compatibility, Debian bumps package sonames whenever symbols are removed from a library.

@dltj
Copy link

dltj commented Nov 2, 2020

Logged in our internal tracker—thank you, @hughmcmaster.

@adamdickmeiss
Copy link
Contributor

I'm inclined to just add those symbols again and use assert(0). This rule is a little rigid.

If this also means a change to the package name (not just version), then I'm very sure that's the best idea.

@hughmcmaster
Copy link
Contributor Author

If the symbols/functions are reinstated as they were and assert(0) added, AIUI that won't be a breaking change and no soname bump is needed. We obviously don't need the problematic test.

In saying that, I can't find any implementations using the removed symbols.

With this course of action, I see no reason to bump the soname, although you should consider bumping the revision to 0:2:0.

@adamdickmeiss
Copy link
Contributor

ok. Bumping that.

@adamdickmeiss
Copy link
Contributor

#23

@hughmcmaster
Copy link
Contributor Author

You'll also need to reinstate the four functions.

@adamdickmeiss
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants