Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--code-signature-flags Is Not Scopable #116

Closed
hafta opened this issue Nov 17, 2023 · 1 comment
Closed

--code-signature-flags Is Not Scopable #116

hafta opened this issue Nov 17, 2023 · 1 comment
Labels
apple-codesign apple-codesign crate and rcodesign CLI tool bug Something isn't working

Comments

@hafta
Copy link

hafta commented Nov 17, 2023

When trying to sign a bundle using rcodesign 0.25.1, the --code-signature-flags argument doesn't accept a path scoped argument. For example, here's an error

error: invalid value 'Contents/MacOS/pingsender' for '--code-signature-flags <CODE_SIGNATURE_FLAGS>'

resulting from

$ rcodesign sign -v \                                                                    
--p12-file ./myDevId.p12 \                                                             
--p12-password-file ./myDevId.p12.passwd \                                             
--code-signature-flags runtime \                                                       
--entitlements-xml-path ./browser.xml \                                                
--entitlements-xml-path Contents/MacOS/plugin-container.app:./plugin-container.xml \
--entitlements-xml-path Contents/MacOS/media-plugin-helper.app:./media-plugin-helper.xml \
--code-signature-flags Contents/MacOS/pingsender:runtime \                             
--code-signature-flags Contents/MacOS/minidump-analyzer:runtime \                      
--code-signature-flags Contents/MacOS/updater.app:runtime \                            
--code-signature-flags Contents/MacOS/crashreporter.app:runtime \                      
--code-signature-flags Contents/MacOS/XUL:runtime \                                    
--code-signature-flags Contents/MacOS/libfreebl3.dylib:runtime \                       
--code-signature-flags Contents/MacOS/liblgpllibs.dylib:runtime \                      
--code-signature-flags Contents/MacOS/libsoftokn3.dylib:runtime \                      
--code-signature-flags Contents/MacOS/libosclientcerts.dylib:runtime \                 
--code-signature-flags Contents/MacOS/libmozavutil.dylib:runtime \                     
--code-signature-flags Contents/MacOS/libmozglue.dylib:runtime \                       
--code-signature-flags Contents/MacOS/libgkcodecs.dylib:runtime \                      
--code-signature-flags Contents/MacOS/libipcclientcerts.dylib:runtime \                
--code-signature-flags Contents/MacOS/libmozavcodec.dylib:runtime \                    
--code-signature-flags Contents/MacOS/libnssckbi.dylib:runtime \                       
--code-signature-flags Contents/MacOS/libnss3.dylib:runtime \                          
--code-signature-flags Contents/Resources/gmp-clearkey/0.1/libclearkey.dylib:runtime \
--code-signature-flags Contents/Library/LaunchServices/org.mozilla.updater:runtime \
Firefox.app
@indygreg indygreg added bug Something isn't working apple-codesign apple-codesign crate and rcodesign CLI tool labels Nov 17, 2023
@indygreg
Copy link
Owner

Bleh. Can't believe this bug has survived as long as it has. Will fix shortly. Thanks for the report.

FWIW if you use config files, it will likely work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-codesign apple-codesign crate and rcodesign CLI tool bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants